Exposing prepared statement fetch size parameter #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having some trouble with the test coverage. There is not a lot of added code here to test, so initially I added some small additions to a couple existing tests, then tried adding a whole new test to see if that made the test coverage happy. Even only adding a What exactly am I doing wrong with the test coverage, or is this expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to issue #299.
This exposes the fetch size parameter on the prepared statement. This is needed for Postgres connections for large data sets, or any connection that does not set a fetch size by default, so that the connection does not attempt to bring back all the data in one giant payload.
https://jdbc.postgresql.org/documentation/head/query.html
I also fixed the tests around reflection. The test coverage library seems to inject synthetic fields in all Java classes for measurements. All that needed to be done was filter out the synthetic fields in the reflection unit tests.
I also added a unit test around my change.